Fix Slack file uploads for newer slack_sdk versions - #1
Open
maxkueng wants to merge 2 commits into
Open
Conversation
Author
|
Maybe it's pointless, considering your fraschetti#141 PR has been ignored for over a year, but if you merge this PR you might want to update that other PR as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Slack file uploads with current versions of
slack_sdk.Slack snapshot uploads fail with a
channel_not_founderror when using recent versions ofslack_sdk.files_upload_v2()now expectschannel(singular) when uploading to a single channel, whereas the legacyfiles.uploadAPI usedchannels.There was a transitional period in
slack_sdkwherefiles_upload_v2()still accepted a single channel ID via thechannelsargument for compatibility, which is likely why this fork worked initially. Starting with v3.35.0,channelsis treated as a list of channel IDs, so single-channel uploads should use thechannelargument instead.Since the dependency is specified as
slack_sdk>3.23.0, current installs of the plugin will install newer SDK versions (latest is 3.43.0) and fail when attempting to upload webcam snapshots to Slack.